Remove DPI_AWARE flag and GetVirtualScreenSize workaround#9866
Open
EthanBlazkowicz wants to merge 2 commits into
Open
Remove DPI_AWARE flag and GetVirtualScreenSize workaround#9866EthanBlazkowicz wants to merge 2 commits into
EthanBlazkowicz wants to merge 2 commits into
Conversation
added 2 commits
May 21, 2026 23:41
The DPI_AWARE flag in SimpleGraphic was decoupled from the rendering pipeline - it now only controls the API unit contract. PoB uses virtual units everywhere, so the flag is no longer needed. GetScreenSize now natively returns virtual units, removing the need for the GetVirtualScreenSize workaround that manually divided by the scale factor.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove DPI_AWARE flag and GetVirtualScreenSize workaround
Requires PathOfBuildingCommunity/PathOfBuilding-SimpleGraphic#100
Background
SimpleGraphic PR #100 decoupled the
DPI_AWAREflag's dual responsibilities (rendering pipeline vs API contract). The flag now only controls whether the API uses physical or virtual units. PoB works exclusively in virtual units, so the flag is no longer needed.Additionally,
GetScreenSize()now natively returns virtual units regardless of the flag, making theGetVirtualScreenSize()workaround obsolete.Changes
src/Launch.lua (line 68):
src/Modules/Common.lua (lines 978-986):
What this means
No other files or callers need changes - all consumers of GetVirtualScreenSize() continue working with the same return values.
1.0 to 3.0 DPI scaling all tested.
Code and PR Co-Written by DeepSeek