Add abyss sockets to comparison tab#9854
Merged
LocalIdentity merged 7 commits intoMay 17, 2026
Merged
Conversation
Contributor
Author
If the comparison item has abyss sockets, the abyss sockets are emptied on the primary build, and then replaced with jewels from the comparison build. This seems to work alright for showing the power of abyss jewels in items. One problem though is that the tooltip doesn't include these sockets in the stat diff. But really this seems like a separate issue. I reckon it would be a decent idea to link jewels to items, similar to augments in pob2. |
Contributor
Author
Weapon swaps also show on the items tab. They aren't included in the power report |
LocalIdentity
approved these changes
May 17, 2026
We were not using the item id to use when resetting causing jewels to not equip after running the compare to another build with an abyss jewel
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes lack of abyss sockets in comparison tab.
Steps taken to verify a working solution:
Link to a build that showcases this PR:
https://pobb.in/d6CYO2E54PHy
After screenshot: