Skip to content

Refactor notification channels registration #7

Description

@tindn

Currently, this method https://github.com/Path-Check/background-geolocation-android/blob/master/src/main/java/com/marianhello/bgloc/sync/NotificationHelper.java#L88 allows registration of all channels, and it's being used by https://github.com/Path-Check/background-geolocation-android/blob/master/src/main/java/com/marianhello/bgloc/BackgroundGeolocationFacade.java#L85.

However, the sync service channel is already being registered here https://github.com/Path-Check/background-geolocation-android/blob/master/src/main/java/com/marianhello/bgloc/sync/SyncAdapter.java#L76 and the service channel is being registered here https://github.com/Path-Check/background-geolocation-android/blob/master/src/main/java/com/marianhello/bgloc/service/LocationServiceImpl.java#L225.

Therefore, the registerAllChannels is only effectively registering the permission channel. If this is the case, this method should be refactored to be just permissions channel.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions