Repository navigation
feat(web): Labels and Milestones pages to create, edit and delete them - #257
Conversation
QW-019: there was no web UI to create or manage milestones or labels; the issue picker pointed at 'dg milestone create' and labels could only be created inline, with no recolor, description edit or delete. Issues and Pull requests now carry a Labels | Milestones switch, as on GitHub. /repo/labels lists the labels with links to their issues and PRs and lets members create one (name, description, colour with GitHub's palette and a preview), edit its colour and description, and delete it (the signer's definitions, retiring it first when another member also defined it, parity with dg label delete); retired labels can be restored. /repo/milestones lists open and closed milestones with due dates, descriptions and progress over their issues and PRs, and lets members create, edit, close, reopen and delete them (refused, with close offered, when another member also defined the title). Names and titles stay fixed once defined, since issues carry them by name. Private repositories' milestones stay refused, as in dg. The issue sidebar's pickers link to both pages. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…ne forms against the schema A label delete that writes a retirement was previewed as a single refund, so the affordability check was skipped. The dialog now reads the label's definitions first (planLabelDelete, shared with deleteLabel) and prices the retirement plus each delete. The label and milestone forms now run checkLabelInput and checkMilestoneInput, so input over the byte limit is refused in the form rather than failing at the confirm step. A label name that differs only in case is refused, as in the issue picker, and a retired name points to Restore. Restoring a retired label now opens a form to choose its colour and description instead of picking a random colour. The milestones page reads the milestone documents once instead of twice, tells a failed issue or PR read apart from a feed that is too large, and links the PR list next to the issue list because its counts include PRs. The picker's Manage milestones link opens the list, and only Create a milestone opens the form. issueMilestoneItems and pullMilestoneItems now share rowsWithEvent, which skips a feed entry with no target id. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 1 minute. View limit detailsLimit details: You’ve used the included review currently available. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (28)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…e milestone deletes per definition A retried label delete could replay its cached retirement and then delete it as one of the signer's definitions, bringing another member's definition back. The plan now keeps the signer's own newest retirement, and the delete never removes the document it just wrote. The milestone delete dialog prices one delete per definition the signer wrote. The guide no longer says PRs can be put in milestones, and dg's private-milestone refusal no longer points at the web app, which refuses them too. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
Pre-merge check: I merged origin/master in and ran a code-review-validator pass. The label and milestone write semantics match
Left as is:
Gates after the merge: 🤖 Posted autonomously by Claude on behalf of pasta. |
What
QW-019: there was no web UI for creating or managing milestones or labels. The milestone picker said "No open milestones (
dg milestone create)", and labels could only be created inline, with no way to recolour, redescribe or delete them.Issues and pull requests now have a Labels | Milestones switch beside the search box, as GitHub does. It leads to two new pages, which sit under the Issues tab.
/repo/labelsdg label delete: it removes your definitions of the label. If another member also defined it, a retirement is written first, and the confirm dialog prices exactly that./repo/milestonesmilestone:(from fix(web): apply GitHub's issue and PR search qualifiers, and page past the end #246).Issue sidebar
Also added: short URLs
/owner/repo/labelsand/owner/repo/milestones, page titles, and the header tab.Why this way (the RC1 contracts are frozen)
label(forge-core) andmilestone(forge-community) documents are member-gated, immutable and owner-deletable. The newest definition of a name or title wins.dgdoes yet, so they are refused there with a note. Label definitions are plaintext by design, as the guide already says.Tests
label-milestone-writes.test.ts:deleteLabelin both cases (all definitions yours, and retire-then-delete),defineMilestoneincluding private-repo and schema refusals,deleteMilestonerefusing when another member also defined the title, anddueOnOf/dayOf(matching the CLI'sparse_day).labels-milestones.test.tsx(jsdom):repo-header.test.tsandshort-url.test.ts: the new routes.Gates:
tsc --noEmitclean; the fullvitest runpasses (4411); eslint is clean on the changed files. A code review ran; its fixes are in6adc237e.Live check (bonsia)
Evidence is in
dash-forge-qa/evidence/qa-wave-bonsia/fixes/issues-search/:c1–c3(read-only, qa-issuesprs-main, as a visitor, in both themes at desktop and 390 px): the labels page lists bug and enhancement with no write controls; the milestones page shows v1.0 at 0% complete with 1 open; the Issues list shows the Labels | Milestones switch.c4–c11(this stream's own scratch repoDYXPkp8…/qw-issues-search-scratch, signed in as its owner): a full round trip in the web at desktop light and 390 px dark.🤖 Generated with Claude Code