Repository navigation
feat(web): read forge-v2 repos (protocol 14) with v1 read-compat #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
5feddff
feat(web): read forge-v2 repos through a RepoSource with v1 read-compat
PastaPastaPasta 07f4f74
refactor(web): simplify the forge-v2 read path
PastaPastaPasta c0698df
test(web): pin that repoId-scoped complete reads stay tie-safe
PastaPastaPasta 81d0b88
wip: review fixes before cherry-picking v2_pack_list
PastaPastaPasta 29f39bc
feat(rules): v2_pack_list, the forge-v2 pack list and packRef space
PastaPastaPasta ab3157e
fix(web): address the forge-v2 read review
PastaPastaPasta fe90dae
test(web): follow the pulls-content line the brand-blue allow-list pins
PastaPastaPasta 1a3bf73
fix(web): address CodeRabbit on the forge-v2 reads
PastaPastaPasta File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🗄️ Data Integrity & Integration | 🟡 Minor | ⚡ Quick win
Correct the claim that the v2 pack list reduces to the v1 rule.
Step 5 keeps superseded packs in the list at their original
packRef. The v1 rule (liveGitPackManifestsinlocatorPackSpace) removes superseded packs from the packRef space. After a v1 repack, the two rules therefore give differentpackRefs for every pack listed after the superseded one. The statement is correct only for v1 repos that have never been repacked. Implementers read this section as normative, so a v1 locator built from this text would resolve the wrong packs.Proposed wording
📝 Committable suggestion
🤖 Prompt for AI Agents