Repository navigation
Conversation
|
No actionable comments were generated in the recent review.
 |
| Layer / File(s) | Summary |
|---|---|
Configure and publish DMG names apps/desktop/electron-builder.ts, .github/workflows/release-desktop.yml |
The DMG configuration sets a versioned Paradev filename. The release workflow creates and reports a stable Paradev copy and a legacy Superset copy. Architecture extraction and its fallback remain unchanged. |
Estimated code review effort: 2 (Simple) | ~5 minutes
Change: Other · Severity of issue fixed: Low
Possibly related issues
- ParadevAI/Paradev issue 8934 — Reports that the macOS disk image uses the Superset name; this change adds Paradev artifact names while retaining a legacy copy.
Suggested reviewers: saddlepaddle
Merge Risk: 
94226
-
The naming change is mergeable; packaged-release verification can confirm the emitted filenames during the next release.
Pre-merge checks: 
-
Check name Status Explanation Title check The title clearly identifies the primary change: renaming the macOS installer to Paradev. It uses the required conventional commit format. Description check The description explains the installer filename change, legacy artifact compatibility, scope exclusions, and verification status. It does not include the template checklist and does not report a packa… Docstring Coverage No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat… Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Full details: Description check
-
Explanation
The description explains the installer filename change, legacy artifact compatibility, scope exclusions, and verification status. It does not include the template checklist and does not report a packaged build or release-workflow test, but the main required information is present.
Full details: Docstring Coverage
-
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 1 files. (1 skipped: 1 unsupported.)
-
Finishing Touches
-
Generate docstrings
-
- Commit to this branch
- Create a new PR
Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
 [Medium impact] The PR appears safe to merge. SummaryNames the macOS installer
Explicitly deferred by Kitenite:
Reviews (1) · Last reviewed commit: "fix(desktop): name the macOS installer P..." · Reviewed by Greptile |
🚀 Preview Deployment🔗 Preview Links
Preview updates automatically with new commits |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
No issues found across 2 files
Architecture diagram
sequenceDiagram
participant Dev as Developer
participant CI as Release Workflow
participant Builder as electron-builder
participant Artifacts as Build Artifacts
participant GH as GitHub Release
participant Users as End Users
Note over Dev,GH: macOS Installer Distribution Flow
Dev->>CI: Push to release branch
CI->>Builder: Run build (dmg + zip targets)
Note over Builder: electron-builder config
Builder->>Builder: dmg target with artifactName
Note right of Builder: NEW: artifactName = "Paradev-<version>-<arch>.dmg"
Builder->>Builder: zip target (unchanged artifactName)
Builder-->>Artifacts: Paradev-<version>-<arch>.dmg
Builder-->>Artifacts: <app>-<version>-mac.zip (unchanged)
CI->>Artifacts: List produced .dmg files
loop Each .dmg file
CI->>CI: Parse arch from filename
alt Arch suffix detected (e.g., arm64)
CI->>CI: arch = "arm64"
else No arch suffix (x64 build)
CI->>CI: arch = "x64"
end
CI->>Artifacts: Copy to Paradev-<arch>.dmg
Note right of CI: NEW: Stable branded copy for new links
CI->>Artifacts: Copy to Superset-<arch>.dmg
Note right of CI: CHANGED: Legacy copy retained
end
CI->>GH: Upload artifacts to release
GH->>GH: Publish release
Note over Users,GH: Download flows (post-release)
alt New download links (future)
Users->>GH: Request Paradev-<arch>.dmg
GH-->>Users: Paradev-<arch>.dmg
else Existing/legacy links
Users->>GH: Request Superset-<arch>.dmg
GH-->>Users: Superset-<arch>.dmg
end
Note over Users,GH: Auto-update flow
Users->>GH: Check for updates
GH-->>Users: Update feed (mac.zip, unchanged)
Note right of Users: No path or name changes for updates
Part of SUPER-3090.
What changes
dmg.artifactNameinapps/desktop/electron-builder.ts: the installer is nowParadev-<version>-<arch>.dmg. The-mac.zipupdate archive keeps its name, so the auto-update feed is unchanged.release-desktop.ymlpublishes the stableParadev-<arch>.dmgcopy and keepsSuperset-<arch>.dmg, so old links and deployed sites keep working.Not in this PR
Superset.appbundle name: needs theproductNamechange, which moves userData, logs and the keychain entry and changes the Squirrel update path. Needs its own cutover plan and data migration.app.superset.shis pinned on purpose until the host-aware auth work inplans/20261026-app-domain-move.mdships.DOWNLOAD_URL_MAC_*, README, docs, RELEASE.md): still point atSuperset-*.dmg. Switching before a release publishesParadev-*.dmgwould 404 the Download button. Follow-up after the next release.Verification
Biome passes on the changed file. I did not run a packaged build or the release workflow, so the new filename is unverified until a release runs.
Summary by cubic
Names the macOS installer
Paradev-<version>-<arch>.dmgso the distributed app matches the Paradev branding. The release workflow publishes bothParadev-<arch>.dmgand legacySuperset-<arch>.dmgstable copies, so existing download links keep working.Not in this PR
-mac.zipupdate archive keeps its name, so the auto-update feed is unchanged.Superset.appbundle name stays until theproductNamechange ships with its own migration plan for userData, logs, keychain entry, and the Squirrel update path.app.superset.shuntil host-aware auth lands.Superset-*.dmg; switching them before a release would 404 the Download button, so they follow after the next release.Written for commit 942267f. Summary will update on new commits.
Summary by CodeRabbit