Skip to content

ASE-559: upgrade go-billy to v5.9.0 - #837

Merged
BetterAndBetterII merged 2 commits into
mainfrom
fix/ase-559-go-billy
May 16, 2026
Merged

BetterAndBetterII merged 2 commits into
mainfrom
fix/ase-559-go-billy

Conversation

@BetterAndBetterII

Copy link
Copy Markdown
Collaborator

What changed

  • upgrade the resolved github.com/go-git/go-billy/v5 dependency from v5.8.0 to v5.9.0
  • run go mod tidy, which also refreshes related indirect module pins required by the updated module graph

Why

  • Dependabot alert 68 (GHSA-m3xc-h892-ggx6 / CVE-2026-44740) reports that go-billy versions before v5.9.0 can loop indefinitely on crafted symlink structures and exhaust resources
  • main currently resolves go-billy to v5.8.0, so this PR lifts the runtime graph onto the patched release without also taking the broader go-git upgrade

Validation

  • go mod verify
  • go test ./internal/infra/workspace ./internal/workflow ./internal/httpapi ./internal/service/githubauth -count=1
  • go test ./internal/chat -count=1 -run 'Test(ParseWorkspaceBranchName|ParseWorkspaceBranchNameRejectsInvalidValue|ProjectConversationWorkspaceRepoRefsDetectDetachedHEAD|ProjectConversationWorkspaceGitGraphListsLabelsAndHead|ProjectConversationWorkspaceCheckoutRejectsDirtyWorkspace|ProjectConversationWorkspaceCheckoutCreatesTrackingBranchAndRefreshesMetadata|ProjectConversationWorkspaceCheckoutCreatesNewLocalBranch|ProjectConversationWorkspaceCheckoutRemoteBranchReportsExistingLocalTrackingBranch|ProjectConversationWorkspaceCheckoutRejectsExistingNewLocalBranch|ProjectConversationWorkspaceStageAndCommitFile|ProjectConversationWorkspaceDiscardFileRestoresWorkspaceState|ProjectConversationWorkspaceStageAllAndUnstageFile|ProjectConversationWorkspaceUnstageAllRestoresUnstagedState|SummarizeConversationWorkspaceRepoHandlesUnbornHead|SummarizeConversationWorkspaceRepoMissingGitDirectoryStillSkipped)$'
  • make check currently still fails in pre-existing unrelated tests: internal/chat TestConversationTerminalServiceSupportsWebsocketRuntime and internal/orchestrator TestRuntimeLauncherLaunchesWebsocketReverseRuntimeWithHooksAndArtifactSync

Relates to ASE-559.

@BetterAndBetterII

Copy link
Copy Markdown
Collaborator Author

Re-checked before Preview Deploy:

  • branch fix/ase-559-go-billy is synced with main at c72b68ba
  • local validation re-ran clean:
    • go mod verify
    • go test ./internal/infra/workspace ./internal/workflow ./internal/httpapi ./internal/service/githubauth -count=1
    • go test ./internal/chat -count=1 -run 'Test(ParseWorkspaceBranchName|ParseWorkspaceBranchNameRejectsInvalidValue|ProjectConversationWorkspaceRepoRefsDetectDetachedHEAD|ProjectConversationWorkspaceGitGraphListsLabelsAndHead|ProjectConversationWorkspaceCheckoutRejectsDirtyWorkspace|ProjectConversationWorkspaceCheckoutCreatesTrackingBranchAndRefreshesMetadata|ProjectConversationWorkspaceCheckoutCreatesNewLocalBranch|ProjectConversationWorkspaceCheckoutRemoteBranchReportsExistingLocalTrackingBranch|ProjectConversationWorkspaceCheckoutRejectsExistingNewLocalBranch|ProjectConversationWorkspaceStageAndCommitFile|ProjectConversationWorkspaceDiscardFileRestoresWorkspaceState|ProjectConversationWorkspaceStageAllAndUnstageFile|ProjectConversationWorkspaceUnstageAllRestoresUnstagedState|SummarizeConversationWorkspaceRepoHandlesUnbornHead|SummarizeConversationWorkspaceRepoMissingGitDirectoryStillSkipped)$'
  • CI remains green for the changed-path checks

Ready for Preview Deploy / review.

@BetterAndBetterII
BetterAndBetterII merged commit 0458b86 into main May 16, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant