Repository navigation
feat(gitprovider): add optional DescribeIdentity operation - #17
Merged
Merged
Conversation
Identities created outside a setup flow (a plugin's data migration) reach core without a handle, and the SPI had no way to ask who they are: an Identity only came back from CompleteIdentitySetup. DescribeIdentity, advertised by the new identity_description capability, returns the Identity for an existing IdentityRef so core can fill in handle, display name and expiry. Additive: stays gitprovider.v1. Refs Paca-AI/paca#661 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…s not declared Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
pikann
approved these changes
Nov 3, 2026
pikann
left a comment
pikann
left a comment
Contributor
There was a problem hiding this comment.
LGTM! Thank you for the contribution! 🚀
This was referenced Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an optional
IdentityDescriberinterface, advertised by theidentity_descriptioncapability: a provider says who an existing identity is, without a setup flow.Why
Implements Paca-AI/paca#661. A plugin's data migration creates identities without calling the platform, so they have no handle, and the SPI had no way to ask for it: an
Identityonly came back fromCompleteIdentitySetup. Such a connection stays nameless in Settings → Git and cannot be@mentioned.Changes
IdentityDescriber,DescribeIdentityRequestand theidentity_descriptioncapability.identity_descriptionanswersdescribe_identitywith 501.gitprovider.v1.Tests
go vet,go test -race ./...(126 passed), golangci-lint (0 issues) and the wasip1 build, on top of the optional issue listing (#15). Used end to end by the core and plugin PRs below.Merge order
🤖 Generated with Claude Code