Repository navigation
feat: update permission checks and documentation for IAM actions - #12
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Documentation-only update for the IAM authorization model. The
Permissionshelper now documents thatChecktakes an IAM action (<domain>:<verb>) and is decided by the host the same way therequireActionsroute middleware decides it.No API or behavior change:
Permissions.Check(string) bool,PermissionBackendand thepaca.permission_checkhost import keep their signatures.Changes
backends.go: rewrite thePermissionsandPermissions.Checkdoc comments. They described the removed flat permission keys and therequirePermissionsmiddleware, and now describe IAM actions (built-in such astasks:write, or plugin-declared such astime_logging:manage_all) andrequireActions.wasm_imports.go: document thatpaca.permission_checktakes an IAM action.plugintest/backends.go: theFakePermissionsexample usestime_logging:manage_allinstead of the dotted form, so tests grant the same string the host checks.Notes for plugin authors
Plugins calling
Permissions.CheckorFakePermissions.Grantmust use the colon form (tasks:write, nottasks.write). The first-party plugins are updated in their own PRs (feat/iam-actionsin eachpaca-plugin-*repo).Testing
Comment-only change; the package builds unchanged.
🤖 Generated with Claude Code