Skip to content

fix(agent-runner): bound unauthenticated ACP bridge handshakes - #708

Merged
pikann merged 3 commits into
Paca-AI:masterfrom
siedlegroup:security/acpbridge-hello-limit
Nov 6, 2026
Merged

fix(agent-runner): bound unauthenticated ACP bridge handshakes#708
pikann merged 3 commits into
Paca-AI:masterfrom
siedlegroup:security/acpbridge-hello-limit

test(agent-runner): satisfy bodyclose and noctx in the hello-limit tests

a76e285
Select commit
Loading
Failed to load commit list.
Pullfrog / pullfrog succeeded Nov 6, 2026 in 2m 39s

Pullfrog run completed

The Pullfrog run finished successfully.

No new issues. The only changes since the prior review (8f3bf99 → a76e285) are test-only lint compliance in server_hello_test.go (bodyclose/noctx): closing the websocket.Dial response body when non-nil (a no-op on success in coder/websocket v1.8.15, which nils resp.Body) and switching the 503 test to http.NewRequestWithContext. Semantics are unchanged and go test ./internal/acpbridge -run TestHandleWS -count=1 passes. Both prior Pullfrog threads are already resolved.

Task list (6/6 completed)
  • Checkout PR #708 and read incremental diff
  • Read PR summary snapshot and learnings
  • Fetch prior reviews and retire addressed Pullfrog threads
  • Triage incremental changes and dispatch specialists if needed
  • Aggregate findings, draft review, update summary snapshot
  • Submit review or report no-review-needed
View more details on Pullfrog