Repository navigation
fix(git): keep loaded repositories on a failed page and drop the cursor cap - #695
Merged
Merged
Conversation
…or cap The repository cursor is opaque and issued by the provider, so a length cap on it could break page 2; only the search text stays capped. A failed "Load more" now shows the error next to the button instead of replacing the list that was already loaded. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
![pullfrog[bot]](https://avatars.githubusercontent.com/in/1768019?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
ℹ️ Minor suggestions only — one small cleanup inline.
Reviewed changes
Follow-up to #691 that resolves both of that review's inline suggestions. Reviewed commit 4eefec7.
- API cursor cap removed —
ListAvailableRepositoriesno longer rejects acursorover 1024 bytes; only the 200-characterqbound stays, and the message is nowsearch is too long. The provider plugin host already caps inbound bodies, so this is safe. - Web keeps loaded pages on a failed page —
GitRepositoryPickergates the full-list error replacement on!list.dataand otherwise shows the same alert above the Load more button, so a failed next page no longer wipes the repositories already on screen. - Tests — the Go handler test adds a 5000-character cursor that must pass, and the vitest case pins a failed second page keeping the first page's items with Load more still enabled.
Note: 1 inline comment(s) dropped because they did not anchor to lines inside the PR diff:
services/api/internal/transport/http/handler/git_handler_test.go:762-767(RIGHT) — line 767 (RIGHT) is not inside a diff hunk
deepseek-v4.1-flash (free via Pullfrog for OSS) ｜ 𝕏
pikann
approved these changes
Nov 3, 2026
pikann
left a comment
pikann
left a comment
Contributor
There was a problem hiding this comment.
LGTM! Thank you for the contribution! 🚀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #691, addressing the two review suggestions.
qstays).Tests: Go handler test now asserts a long cursor passes through; vitest covers a failed second page keeping the list.
🤖 Generated with Claude Code