Repository navigation
test: cover change-request edited events for title and description changes - #4
Merged
Merged
Conversation
…anges Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
pikann
approved these changes
Oct 29, 2026
pikann
left a comment
There was a problem hiding this comment.
LGTM! Thank you for the contribution! 🚀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two conformance fixtures for merge request
updatehooks that change the title or the description. Both must produce achange_request/editedevent.Why
Core re-reads the title on
editedto link tasks (PROJ-Nadded to an existing MR's title). While testing end to end, a title edit seemed to produce no event. The provider handles this case correctly (mergeRequestinspi_webhook.go), and the missing events came from a failed hook registration in my test setup. These fixtures pin the behaviour so it doesn't regress.Test-only change, no runtime code touched. Related: Paca-AI/paca#656 (item 4, core keeps the state of a closed MR on
edited).Tests
go vet ./...andgo test -race ./...inbackend/.🤖 Generated with Claude Code