Repository navigation
Fix WS LED configuration and battery voltage indication - #63
Open
MariuszBak wants to merge 1 commit into
Open
MariuszBak wants to merge 1 commit into
MariuszBak wants to merge 1 commit into
Conversation
bartekM-pl
reviewed
Oct 27, 2026
bartekM-pl
left a comment
bartekM-pl
left a comment
Member
There was a problem hiding this comment.
Overall great PR. I only have one comment regarding changes in main.c
Member
There was a problem hiding this comment.
It would be great to move all of this somewhere else. Maybe it will be good idea to make a new component dedicated to battery management. This way we can implement for ex. fuel gauge, battery discharge model etc. in the future.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.