Skip to content

fix(shell): xargs runs its COMMAND batches through the exec chain, not u-root os/exec - #426

Merged
PHPCraftdream merged 1 commit into
mainfrom
fix/xargs-exec-chain-20261115
Nov 15, 2026
Merged

PHPCraftdream merged 1 commit into
mainfrom
fix/xargs-exec-chain-20261115

Conversation

@PHPCraftdream

Copy link
Copy Markdown
Owner

Windows: xargs no longer opens console windows (#156)

With the Go coreutils on (the Windows default) xargs was u-root's, which starts every batch with a bare os/exec call. That skipped the sanctioned process handler: on Windows each batch opened a console window (no CREATE_NO_WINDOW; hundreds per minute in find | xargs basename loops of agents), and the command ran with the rush process's working directory and environment instead of the shell's, outside its kill handling.

The xargs middleware now reads the items itself and hands each batch to the handler chain below it. -p and unknown options stay with u-root; the first failing batch still ends the run. Regression tests: batches reach the exec chain (a probe that is not an executable can only be reached through it), the first failing batch stops the run, plan and input parsing. Revert check: routing batches back to u-root makes the chain tests fail with executable file not found.

Full fork CI run 43747079949 on ca6c8a256 is green (22 jobs).

🤖 Generated with Claude Code

…t u-root os/exec

With the Go coreutils on (the Windows default) xargs was u-root's, which starts
every batch with a bare os/exec call. That skipped the sanctioned process
handler: on Windows each batch opened a console window (no CREATE_NO_WINDOW;
hundreds per minute under find | xargs basename loops of agents), and the
command ran with the rush process's working directory and environment instead
of the shell's, outside its kill handling. The xargs middleware now reads the
items and hands each batch to the handler chain below it. -p and unknown
options stay with u-root. The first failing batch still ends the run.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
@PHPCraftdream
PHPCraftdream merged commit 579e26f into main Nov 15, 2026
1 check passed
@PHPCraftdream
PHPCraftdream deleted the fix/xargs-exec-chain-20261115 branch November 15, 2026 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant