Repository navigation
fix(shell): xargs runs its COMMAND batches through the exec chain, not u-root os/exec - #426
Merged
Merged
Conversation
…t u-root os/exec With the Go coreutils on (the Windows default) xargs was u-root's, which starts every batch with a bare os/exec call. That skipped the sanctioned process handler: on Windows each batch opened a console window (no CREATE_NO_WINDOW; hundreds per minute under find | xargs basename loops of agents), and the command ran with the rush process's working directory and environment instead of the shell's, outside its kill handling. The xargs middleware now reads the items and hands each batch to the handler chain below it. -p and unknown options stay with u-root. The first failing batch still ends the run. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows: xargs no longer opens console windows (#156)
With the Go coreutils on (the Windows default)
xargswas u-root's, which starts every batch with a bareos/execcall. That skipped the sanctioned process handler: on Windows each batch opened a console window (noCREATE_NO_WINDOW; hundreds per minute infind | xargs basenameloops of agents), and the command ran with the rush process's working directory and environment instead of the shell's, outside its kill handling.The xargs middleware now reads the items itself and hands each batch to the handler chain below it.
-pand unknown options stay with u-root; the first failing batch still ends the run. Regression tests: batches reach the exec chain (a probe that is not an executable can only be reached through it), the first failing batch stops the run, plan and input parsing. Revert check: routing batches back to u-root makes the chain tests fail withexecutable file not found.Full fork CI run 43747079949 on
ca6c8a256is green (22 jobs).🤖 Generated with Claude Code