Repository navigation
refactor: sprint 0 wave 3 (layer linter, second ratchet, db split into migrater and dbconn) - #423
Merged
Merged
Conversation
…d layer linter Three guards with selftests and falling ratchet lists, wired into pre-push, pre-push-fast and the checks job: all hand-written code files of a directory including tests at most 21 (seeded with 25 directories), files above 900 lines may not grow (seeded with 38), and imports may only point down the groups kit < store < session < config < agent < app < serve (no production violations; two test files seeded, internal/agent/supervision_notice_binding_app_test.go and internal/config/task1314_oauth_disk_sync_test.go). Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
… db/migrater DB-A of the db split: migrater owns the schema migrations (embedded, closed behind ActiveFS), the legacy store importer (split into the policy/driver half and the copying half), the SQLite driver pair with the pragma set and BusyTimeout, and Migrate. Only the intended hunks change: renamed exports, qualified call sites in connect.go, sdk, app, session and cmd, a local requireTableExists copy and dbtest.OpenFK/OpenSingle for tests that crossed the boundary. sqlc generate is a no-op with the new schema path; the db ratchet entry falls 16 -> 9 and ci-policy owners follow the new migrations path. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
DB-B of the db split: compact, the free-space probe and its OS pair move to db/dbconn; sessions compact calls them there. internal/store/db reaches 7 elements and leaves the dir-entries ratchet. compact_test.go keeps db.Connect/db.ReleaseAll qualified until the pool itself moves (DB-C). Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…update pinned seeds The db split leaves internal/store/db at 7 elements and 13 files with tests, so its dir-entries line (previous commit) and its dir-files line leave the ratchets; the real-repository selftest cases pin the new seeded sizes (38 and 24). Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…e migrating The local openFixture copy lost the cleanup and the ping of the original helper, so the store file stayed open and TempDir removal failed on Windows. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
The modernc-only dbtest.go left OpenFK and OpenSingle undefined under GOOS=linux GOARCH=mips64, so golangci-lint of ./internal/store/db/... failed there. The negated-constraint twin mirrors the fixture pragmas. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wave 3 of sprint 0.
Verified by the full fork CI run 43707656116 on 5458965 (all jobs green). The only difference between this head and the result of the merge is docs/plans from PR 422.
🤖 Generated with Claude Code