fix: pass silent=true on alarm delete requests - #849
Merged
Conversation
DeleteByUidAsync and BulkDeleteByUidsAsync never suppressed PoracleNG's delete-confirmation DM, unlike CreateAsync which already does. Every delete -- single, bulk, cleaning-service reset, admin delete-all -- sent one Discord message line per removed alarm listing its full filters. Fixes #848
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DeleteByUidAsyncandBulkDeleteByUidsAsyncnever suppressed PoracleNG's delete-confirmation DM, unlikeCreateAsyncwhich already passes?silent=true.?silent=true, matching the create path. Covers all ten alarm types since they share one proxy class.Fixes #848
Test plan
PoracleTrackingProxyTests.csto expect?silent=truedotnet test— full backend suite passes (2595/2595)