Redo my old improper fix for #3580 (undoes 655f36e) - #99
Merged
CaitlynMainer merged 1 commit intoSep 14, 2026
Merged
CaitlynMainer merged 1 commit into
CaitlynMainer merged 1 commit into
Conversation
`process.removeHandle(mt.process, t)` was incorrect argument order and causing weird issues with the `thread` API. The new fix fixes a check that was the actual root cause of the issue, by acknowledging the fact that `process.info()` returns a new table every time--but for a given process, the `data` field of this table will always be the same.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
process.removeHandle(mt.process, t)was incorrect argument order and causing weird issues with thethreadAPI. The new fix fixes a check that was the actual root cause of the issue, by acknowledging the fact thatprocess.info()returns a new table every time--but for a given process, thedatafield of this table will always be the same.