Repository navigation
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
All values were one less than the Office ones, starting with msoAlignLeft = 0 instead of 1, so e.g. msoAlignCenter aligned the text to the left. The values were checked with the Office type library. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
xlThemeFontMajor and xlThemeFontMinor had their values swapped, so setting the major (headings) theme font set the minor (body) one and vice versa. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
It had the value of msoShapeSnip2DiagRectangle, so a rectangle with two snipped corners was added instead of the one with two rounded corners. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
msoEffectNone was 17 instead of 0, the values following msoEffectMosaicBubbles were one higher than in Office, and those of msoEffectChalkSketch, msoEffectColorTemperature, and msoEffectCrisscrossEtching were mixed up. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
msoContactCardAddressTypeIM had the value of msoContactCardAddressTypeOutlook. Add the missing msoMetaPropertyTypeUserMulti, msoMetaPropertyTypeBusinessData, and msoMetaPropertyTypeBusinessDataSecondary, and set msoMetaPropertyTypeMax to the value following them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The mixed value of MsoSoftEdgeType was named SoftEdgeTypeMixed, without the prefix used in Office. Keep the old name, so that the code using it still compiles, but mark it as deprecated. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Indexing a collection with a string literal, e.g. styles["Normal"], did
not compile, as the call was ambiguous: the built-in subscript
"Normal"[index] could be used too, with the collection converted to a
number by its operator bool. Replace operator bool in wxExcelObject with
a conversion template allowing only bool, so that objects still convert
to bool everywhere they did, e.g. in conditions, initializing a bool, or
returning from a function returning bool, but not to a number.
Use string literals instead of wxString("...") as indices in the
samples, and test indexing with literals.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wxAutoExcel 2.7.0.
Library
MsoParagraphAlignment: all values were one less, somsoAlignCenteraligned the text to the left.XlThemeFont:xlThemeFontMajorandxlThemeFontMinorwere swapped.msoShapeRound2DiagRectanglehad the value ofmsoShapeSnip2DiagRectangle.MsoPictureEffectType: 15 values were wrong, e.g.msoEffectNonewas 17 instead of 0.msoContactCardAddressTypeIMandmsoMetaPropertyTypeMaxhad wrong values.msoSoftEdgeTypeMixed(the oldSoftEdgeTypeMixedis kept but deprecated) and the missingMsoMetaPropertyTypevalues.operator bool()ofwxExcelObjectwas replaced with a conversion template allowing only bool. Objects still convert to bool wherever they did (conditions, initializing a bool, returning from a function returning bool), but no longer to numbers, e.g.long n = obj;. Thanks to this, collections can be indexed with string literals, e.g.styles["Normal"], which did not compile because the call was ambiguous with the built-in subscript"Normal"[index].The enum values are changed in a minor version, as code relying on the wrong values may behave differently.
Tests and samples
wxString("...").msoAlignCenterworks.Built with MSVC (Debug and Release), MinGW UCRT64 (DLL and static, Debug and Release), and clang64 (DLL, Debug, against wxWidgets built with clang) with no warnings; all 231 test cases pass in each configuration.
🤖 Generated with Claude Code