Expose global bone transforms to Lua - #832
Merged
Merged
Conversation
adriengivry
approved these changes
Sep 1, 2026
adriengivry
left a comment
Member
There was a problem hiding this comment.
Didn't test but the code looks good!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds read-only access to the accumulated pose of a skinned mesh bone through
CSkinnedMeshRendererand Lua:GetBoneGlobalPositionGetBoneGlobalRotationGetBoneGlobalScaleThe getters resolve a bone index to its skeleton node and decompose the matrix already computed in
m_globalPose. Invalid indices returnstd::nulloptin C++ andnilin Lua, consistently with the existing local bone getters.Related Issue(s)
Fixes #831
Review Guidance
Please focus on:
GetBoneLocalPosition,GetBoneLocalRotation, andGetBoneLocalScaleAPI;The getters read
m_globalPosebefore applying the bone offset matrix, which makes the returned transforms suitable for runtime bone attachments.Screenshots/GIFs
1.mp4
AI Usage Disclosure
N/A
Checklist