raidboss: r12n Combatant Memory netregex matches does not match

[Legends0]

Description

Netreges use matches.pairPosX and matches.pairPosY, but raidboss trigger code is using matches.x and matches.y

Additional Details / Steps to Reproduce

Using code:

    {
      id: 'R12S CombatantMemory Add Tracker',
      // Used for Slaughtershed Stack/Spreads spots
      // 1EBF29 are the blobs
      type: 'CombatantMemory',
      netRegex: {
        id: '4[0-9A-Fa-f]{7}',
        change: 'Add',
        pair: [{ key: 'BNpcID', value: '1EBF29' }],
        capture: true,
      },
      infoText: (_data, matches, output) => {
        const x = parseFloat(matches.x ?? '0')
        const y = parseFloat(matches.y ?? '0')
        return output.text!({ x: x, y: y });
      },
      run: (data, matches) =>
        data.actorPositions[matches.id] = {
          x: parseFloat(matches.x ?? '0'),
          y: parseFloat(matches.y ?? '0'),
          heading: parseFloat(matches.heading ?? '0'),
        },
      outputStrings: {
        text: {
          en: 'Blob Found at (${x}, ${y})',
        },
      },
    },

R12N has basically the same code for creating the actorPosition, but based off this, the raid Emulator always results in the 0 values since those matches do not exist.

Cactbot Module

Raid Emulator

Configuration Info

N/A

Log & Screenshots

Confirmation

• I reviewed Common Issues and Workarounds and verified that my settings are correct.
• I used the search function to confirm this issue doesn't already exist.

[Legends0]

Actually this seems like it's just a bug with the R12N raidboss file. I see FRU using code with pairPosX.

Code from R12N:

    {
      id: 'R12N CombatantMemory Add Tracker',
      type: 'CombatantMemory',
      netRegex: { id: '4[0-9A-Fa-f]{7}', change: 'Add', capture: true },
      run: (data, matches) =>
        data.actorPositions[matches.id] = {
          x: parseFloat(matches.x ?? '0'),
          y: parseFloat(matches.y ?? '0'),
          heading: parseFloat(matches.heading ?? '0'),
        },
    },

My understanding of 261 log lines might be off.

[Legends0]

I'm going to close this, I didn't verify that this is an issue in R12N, it might be R12N log lines are actually using a x, y for what it was needed for, but in my situation I need pairPosX pairPosY.

[valarnin]

This is likely a copy/paste issue.

Due to the dynamic nature of the 261 lines, getting type hinting/propagation to work required the pair<property> setup, rather than just using <property>.

This is an actual bug, so I'm going to re-open the issue, but there's an underlying further need here for a lint rule to catch "invalid property reference on matches" or something along those lines.