Disable Vcpkg for main library - #454
Merged
Merged
Conversation
Only the unit test project uses Vcpkg, and that's for the Google Test dependency. The main library project doesn't have any dependencies. As OP2Utility may be used as a dependency in projects that do use Vcpkg for their own dependencies, it may be helpful here to disable Vcpkg for the OP2Utility project. Part of that is so it doesn't get confused by manifest files in the host project while not having manifests enabled in the this project. Explicitly disabling Vcpkg for this project makes it easier to integrate into project that do use Vcpkg. The other part is that when Vcpkg is enabled it will add to the include search paths and the library search paths, even though it has no dependencies to load. Plus, when built on it's own, it may default to Classic Mode rather than Manifest Mode, so the search path adjustments may be different between projects, which is kind of odd.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only the unit test project uses Vcpkg, and that's for the Google Test dependency. The main library project doesn't have any dependencies.
As OP2Utility may be used as a dependency in projects that do use Vcpkg for their own dependencies, it may be helpful here to disable Vcpkg for the OP2Utility project. Part of that is so it doesn't get confused by manifest files in the host project while not having manifests enabled in the this project. Explicitly disabling Vcpkg for this project makes it easier to integrate into project that do use Vcpkg. The other part is that when Vcpkg is enabled it will add to the include search paths and the library search paths, even though it has no dependencies to load. Plus, when built on it's own, it may default to Classic Mode rather than Manifest Mode, so the search path adjustments may be different between projects, which is kind of odd.
Related:
vcpkgfor dependencies #444