Skip to content

ROU-13064: Fix GetRowData after undo/redo - #530

Merged
os-davidlourenco merged 3 commits into
devfrom
ROU-13064
Oct 1, 2026
Merged

os-davidlourenco merged 3 commits into
devfrom
ROU-13064

Conversation

@os-davidlourenco

@os-davidlourenco os-davidlourenco commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

This PR is for fixing GetRowData returning stale values when OnCellValueChange is raised by undo/redo keyboard shortcuts.

What was happening

  • Undo (Ctrl+Z) and redo (Ctrl+Y) raised OnCellValueChange on undoingAction/redoingAction, before Wijmo applied the cell value.
  • NewValue from the undo action state was correct, but GetRowData still read the pre-undo/redo dataItem, causing a mismatch.

What was done

  • Kept undoingAction/redoingAction handlers only for the search cancel guard.
  • Moved OnCellValueChange triggering (including child _actions) to undoneAction/redoneAction so GetRowData matches NewValue after apply.

Test Steps

  1. Open Sample app.
  2. Manually edit the ID column two times.
  3. Press Ctrl+Z and confirm GetRowData matches NewValue in OnCellValueChange.
  4. Press Ctrl+Y and confirm GetRowData matches NewValue in OnCellValueChange.

Screenshots

(prefer animated gif)

Checklist

  • tested locally
  • documented the code
  • clean all warnings and errors of eslint
  • requires changes in OutSystems (if so, provide a module with changes)
  • requires new sample page in OutSystems (if so, provide a module with changes)

@os-davidlourenco
os-davidlourenco requested a review from a team as a code owner September 29, 2026 10:23
@os-davidlourenco os-davidlourenco added the bug Something isn't working label Sep 29, 2026
@sonarqubecloud

Copy link
Copy Markdown

@os-davidlourenco
os-davidlourenco merged commit d444d78 into dev Oct 1, 2026
12 checks passed
@os-davidlourenco
os-davidlourenco deleted the ROU-13064 branch October 1, 2026 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants