[misc] refactor: simplify internal implementation

[JoyboyBrian]

What

• Simplify duplicated CLI output, authentication, dataset upload, rollout, and template internals without changing public symbols or supported output contracts.
• Consolidate redundant eval and rubric tests while retaining each distinct behavioral assertion.
• Strengthen exact rich-output, JSON key-order, upload cleanup, and cancellation regression coverage.

Why

Reduce internal duplication and maintenance cost while preserving UI/UX, public APIs, trust-boundary validation, recovery behavior, and CLI stdout, stderr, exit codes, and error text.

How to Test

• uv run pytest tests/unit/cli tests/unit/platform/cli tests/unit/cli_services tests/unit/test_cli.py tests/unit/test_rubric_cli_command.py -q
• uv run pytest --cov=osmosis_ai --cov-branch --cov-report=term-missing --cov-report=xml
• uv run ruff check .
• uv run ruff format --check .
• uv run pyright osmosis_ai/
• Run the repository's CI-filtered pyright --verifytypes check; type completeness remains 100% with only the existing Harbor baseline.
• Byte-compare HEAD and this branch for representative JSON, plain, rich, help, version, validation-error, and unknown-command invocations; stdout, stderr, and exit codes match.

Checklist

• Tests added or updated
• Documentation updated if needed
• Public API changes are documented (none)
• Self-reviewed

---

Summary by cubic

Refactors internal implementation across CLI output, authentication, dataset upload, rollout, and template handling without changing public symbols or supported output contracts. Also preserves template wildcard expansion (e.g. configs/*/*.toml) after simplifying catalog path construction.

• Removes duplicated helper functions and flattens conditional branches where it simplifies reading.
• Unifies the simple and multipart dataset upload paths into one flow with identical abort and cleanup behavior.
• Inlines save_trajectory so diagnostics and trajectory writes share a single error-handling path, preserving trajectory failure logs.
• Drops the redundant auth-token assertion from the rollout listener; create_callback_app still validates it.
• Preserves exact CLI stdout, stderr, exit codes, error text, and JSON key order.

Test coverage

• Merges duplicated eval, rubric, and upload tests while retaining every distinct behavioral assertion.
• Strengthens regression coverage for exact rich output, JSON key order, upload interruption cleanup, cancelled concurrency waiters, and template non-terminal wildcard expansion.

^{Written for commit eda200f. Summary will update on new commits.}

[chatgpt-codex-connector]

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
🔒 Security Review	✅ Completed 2026-08-30T09:53:45.084703Z	275d66b	PR opened

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

[codecov]

Codecov Report

❌ Patch coverage is 85.00000% with 3 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
osmosis_ai/rollout/utils/http.py	33.33%	1 Missing and 1 partial ⚠️
osmosis_ai/platform/auth/flow.py	66.66%	0 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

[cubic-dev-ai]

All reported issues were addressed across 25 files

<sub>Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic</sub>

[cubic-dev-ai]

No issues found across 25 files

Confidence score: 5/5

• Automated review surfaced no issues in the provided summaries.
• No files require special attention.

_{Re-trigger cubic}