fix: action the CodeRabbit review of the 0.27.0 changeset

[enieuwy]

Actions CodeRabbit's review of the 0.27.0 production changeset (#47, a review-only PR, because CodeRabbit never finished a review on #36–#44 and refuses closed PRs).

Each finding was checked against the code. Each fix has a test that fails without it.

Finding	Verdict	Change
items tags --batch: request-level 409	valid (Major)	Exits 5 with exactly one JSON envelope. It used to append a second document, and --idempotent reported an already_exists no-op with exit 0.
items create --via connector: recovered SaveItems error	valid (Major)	When every item is recovered, the target collection is still filed. It used to skip filing and report success.
tags rename: typed setup error	valid (Minor)	An invalid config exits 10 (as with every other command) instead of 5.
Batch writes in verify mode	valid (Minor)	The client's synthetic verify response is a no-op, not a malformed envelope.
searches materialize child members	not valid	Zotero forbids child items in collections (schema triggers; child JSON has no collections), so --prune can never see one as a member.
GuardedDB read keyword trust	not reachable	The only user-supplied SQL (MCP sql) runs on a mode=ro connection. Every other guarded read is a code-authored constant. Filed in rumen as P3 defence in depth. A 178-line token gate was written and reverted, because it adds release risk with no reachable defect behind it.

make ci passes. The raw log has no panic:, DATA RACE, FAIL or (cached).

Summary by CodeRabbit

• Bug Fixes
  • Batch tag operations now report request-level HTTP 409 failures in a single result envelope, with exit code 5; per-item conflicts continue to use exit code 1.
  • In verify mode, batch tag operations complete without treating the simulated write response as an error.
  • When connector items are recovered after a save error, the requested target is filed when possible. If filing fails, results include filing details and advise retrying filing only.
  • tags rename now preserves configuration errors and their exit codes, including exit code 10 for invalid configuration.

[coderabbitai]

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: b56c87b5-7ca1-4cfc-8f00-c2233c423734

📥 Commits

Reviewing files that changed from the base of the PR and between 6021d73 and 3cbc319.

📒 Files selected for processing (9)

• CHANGELOG.md
• internal/cli/batch_item_update.go
• internal/cli/items_create.go
• internal/cli/items_create_test.go
• internal/cli/items_tags_batch_test.go
• internal/cli/items_tags_write.go
• internal/cli/items_tags_write_test.go
• internal/cli/tags_rename.go
• internal/cli/tags_rename_test.go

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

---

📝 Walkthrough

Walkthrough

The changes update batch tag response handling, connector item recovery and target filing, and tags rename error propagation. Tests cover verify-mode writes, request-level conflicts, recovered-item filing outcomes, and configuration errors.

Changes

Batch tag mutations

Layer / File(s)	Summary
Verify-mode response handling internal/cli/batch_item_update.go, internal/cli/items_tags_batch_test.go	Synthetic responses in verify mode bypass per-object index validation. The test checks that batch tag add performs planning reads and no write requests.
Request-level conflict handling internal/cli/items_tags_write.go, internal/cli/items_tags_write_test.go, CHANGELOG.md	Request-level conflicts return the failed batch envelope without appending another JSON document. Tests cover add and remove, HTTP 409 and 412, and idempotence on or off. The changelog distinguishes request-level conflicts from per-item conflicts.

Connector item recovery

Layer / File(s)	Summary
Recovered-item target filing internal/cli/items_create.go, internal/cli/items_create_test.go, CHANGELOG.md	When all items are recovered after a connector save error, the command attempts target filing. If filing fails, recovered-item results include filing details and retry-filing-only guidance. Tests cover successful filing, filing failure, and partial recovery.

Tags rename error handling

Layer / File(s)	Summary
Preserve selection setup errors internal/cli/tags_rename.go, internal/cli/tags_rename_test.go, CHANGELOG.md	Tags rename returns existing CLI errors unchanged during selection-client setup. A test checks that malformed configuration produces the same error and exit code as tags list.

Priority: ⬇️ Low

Estimated code review effort: 3 (Moderate) | ~25 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 3cbc3

No issue identified in these changes prevents merging after normal checks.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 61.54% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 13 functions across 8 files. (1 skipped: …	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately identifies the pull request as addressing findings from the CodeRabbit review of the 0.27.0 changeset. It is somewhat broad but remains clear and related to the main purpose of th…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

Full details: Docstring Coverage

Explanation

Docstring coverage is 61.54% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 13 functions across 8 files. (1 skipped: 1 unsupported.)

• Fix all pre-merge checks with AI

✨ Finishing Touches 💡 1

📝 Generate docstrings 💡

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[enieuwy]

@coderabbitai review

[coderabbitai]

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.