Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Process-based inference previously shared or inherited mutable RNG state. Changing worker count or task scheduling could therefore change sampled evidence and support counts, even for the same saved traces. This gives generation, cross-trace collection, and precondition tasks deterministic RNG streams keyed by their semantic identity. Serial and process paths use the same scopes. Precondition downsampling keeps its existing seed-42 sample choices without reseeding the application's global RNG.
Targets
daniel/parallel-inferso this PR contains only the sampling fix and its regression tests. Sampling rates and caps are unchanged; moving to task streams can change the selected subset once compared with the previous serial implementation.Validation:
git diff --check.The real-workload matrix used Python 3.10.16, PyTorch 2.2.2, pandas 2.3.3, fork, and fixed
PYTHONHASHSEED=0. This establishes agreement for the tested inputs and worker counts; it does not claim whole-engine determinism across Python versions, hash seeds, or reordered inputs. Existing set-population ordering and reservoir merge/cap defects remain separate. Two macOS subprocess cases hit OpenMP shared-memory initialization failures; the complete suite passed on Linux.Reproduce the regression suite: