Skip to content

[LOW] — Service layer is largely untested; only app.controller.spec.ts exists across the entire src/ tree #20

Description

@ibrahimmosouf-png

Severity: Low
Type: Testing
Scope: Repository-wide
Labels: testing, help wanted, Official Campaign

Description

A repository-wide search for *.spec.ts files confirms a single test file exists: src/app.controller.spec.ts. None of the services (DonationsService, CampaignsService, MilestonesService, UsersService, AdminService, StellarTransactionsService, SorobanService, NotificationsService, EmailService, StellarEventService) have unit tests. The e2e/ directory contains only app.e2e-spec.ts with no positive test coverage.

Given the complexity of the donation + campaign balance + refund flows (issues #1, #2, #8, #12, #15), the absence of regression tests materially increases the cost of safe changes.

Recommendation


Activity

  1. Adeolu01 commented on Jun 18, 2026

    @Adeolu01
    Contributor

    Hello miantainer, I'm a fullstack engr. and I have accessed this issue and I can resolve it. Please assign this issue to me.

  2. added
    GrantFox OSSIssue tracked in GrantFox OSS
    Maybe RewardedIssue may be eligible for a GrantFox reward
    Official CampaignAudit finding under the Official Campaign
    on Jun 18, 2026
  3. grantfox-oss commented on Jun 18, 2026

    @grantfox-oss

    🦊 GrantFox — @Adeolu01 has been assigned to this issue as part of the Official Campaign campaign!

    Next steps:

    1. Open a Pull Request referencing this issue (e.g., Closes #20)
    2. Your PR will be reviewed by the OrbitChainLabs maintainers

    Good luck! Track your progress on GrantFox.

  4. grantfox-oss commented on Jun 20, 2026

    @grantfox-oss

    🎉 This issue has been marked as completed on GrantFox as part of the Official Campaign campaign!

    @Adeolu01's PR #27 was approved and merged by @Alqku.

    🏆 @Adeolu01: You earned 35 FoxPoints for this contribution! Your current tier: Explorer (48 total points). Track your full progress on GrantFox.

    👏 Great work, @Adeolu01! Keep contributing to OrbitChainLabs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

GrantFox OSSIssue tracked in GrantFox OSSMaybe RewardedIssue may be eligible for a GrantFox rewardOfficial CampaignAudit finding under the Official Campaignhelp wantedExtra attention is neededtestingTest coverage, fuzzing, invariants

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions