Repository navigation
[CRITICAL] — Idempotent createDonation path returns a stale FAILED / PENDING row without re-verifying on-chain status, permanently masking recovered donations #2
Description
Activity
Hi maintainer, I'd like to work on this issue. My approach is to improve the idempotent flow by re-validating on-chain state whenever an existing donation is still
PENDINGorFAILED, updating the stored record before returning the response. I'll also add a bounded re-validation window to prevent excessive Horizon/RPC calls during retry storms, include arecoveredflag so clients can distinguish refreshed results from cached responses, and add tests covering stale status recovery, retry behavior, and idempotent responses.🦊 GrantFox — @Just-Bamford has been assigned to this issue as part of the Official Campaign campaign!
Next steps:
- Open a Pull Request referencing this issue (e.g.,
Closes #2) - Your PR will be reviewed by the OrbitChainLabs maintainers
Good luck! Track your progress on GrantFox.
- Open a Pull Request referencing this issue (e.g.,
🎉 This issue has been marked as completed on GrantFox as part of the Official Campaign campaign!
@Just-Bamford's PR #34 was approved and merged by @Alqku.
🏆 @Just-Bamford: You earned 35 FoxPoints for this contribution! Your current tier: Explorer (433 total points). Track your full progress on GrantFox.
👏 Great work, @Just-Bamford! Keep contributing to OrbitChainLabs.
Severity: Critical
Type: Bug
Scope: Donations, Stellar
Labels:
bug,help wanted,Official CampaignDescription
DonationsService.createDonation(src/donations/donations.service.ts, lines ~46–72) short-circuits whenprisma.donation.findUnique({ where: { txHash } })returns a row, returning the previously storedDonationResponseDtoverbatim. There is no live re-check against Horizon or the Soroban RPC, even when the storedstatusisPENDINGorFAILED.Concrete impact:
verifyDonationOnChainpolled during a Stellar RPC outage and storedFAILED, but the transaction actually succeeded on-chain, every subsequent POST with the sametxHashreturns the staleFAILEDrow. The user's UI shows the donation was rejected even though it is in the ledger.REFUNDEDand the user retries, the idempotent path returns the pre-refundCONFIRMEDpayload.Recommendation
donation.statusisPENDINGorFAILED, re-runstellarTxs.verifyDonationTransactionand update the row before returning.recovered: booleanflag in the response so consumers can tell a fresh confirmation apart from a cached one.