fix: move assignMessageRefs after prune to prevent orphan alias leak#565
Open
zhexulong wants to merge 2 commits into
Open
fix: move assignMessageRefs after prune to prevent orphan alias leak#565zhexulong wants to merge 2 commits into
zhexulong wants to merge 2 commits into
Conversation
merge dev into master
v3.1.12 - Version bump
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch fixes the "Message ID alias capacity exceeded" crash (closes #549) by reordering the
createChatMessageTransformHandlerpipeline.Root Cause
In
lib/hooks.ts,assignMessageRefsran beforeprune. Every message in the conversation received anmXXXXalias viaassignMessageRefs, but thenprune(viafilterCompressedRanges) removed some messages from the array — those now-orm messages never got their aliases cleaned up fromstate.messageIds. Over a long session, these orphan aliases accumulated until the 9999-ref limit was hit, crashing the session.Fix
lib/hooks.ts: MovedassignMessageRefs(state, output.messages)from beforeprune()to after it. Now only survivors of the prune pass get aliases. No alias leak, no capacity exhaustion.Verification
tests/message-ids.test.ts: Added a RED→GREEN integration test that goes throughcreateChatMessageTransformHandlerwith real prune state. On the old pipeline order the test FAILs (proving the leak); on the new order it PASSes.npm test: 87/87 passnpm run typecheck: clean