Skip to content

INTENT-4 §11: session-scoped intent registration#45

Draft
JarbasAl wants to merge 5 commits into
devfrom
spec/intent4-session-scoped
Draft

INTENT-4 §11: session-scoped intent registration#45
JarbasAl wants to merge 5 commits into
devfrom
spec/intent4-session-scoped

Conversation

@JarbasAl

@JarbasAl JarbasAl commented May 28, 2026

Copy link
Copy Markdown
Member

Companion issue: #47

Summary

Every intent registration is automatically keyed by session_id from context.session.session_id — no wire-shape change needed. "default" is the global/inherited scope; all sessions inherit it. Session-scoped registrations extend the pool; the existing blacklist fields are the sole narrowing mechanism.

Effective pool for session X: default intents ∪ session-X intents − blacklisted entries

Dispatch of session-scoped intents routes back through the bridge transparently via existing MSG-1 destination-based routing (BRIDGE-1 §3.2).

Changes

  • §1 scope — add session-scoped registration to defined list
  • §8.1 — replacement key is now quintuple (session_id, skill_id, intent_name, lang, method); session_id read from context.session.session_id, never from message.data
  • §8.4ovos.skill.deregister gains optional session_id field for bulk satellite cleanup on disconnect
  • §10.1ovos.intent.list gains optional session_id filter returning the effective pool (default ∪ session-specific); response entries include session_id
  • §11 (new) — full model: indexing, inheritance rule, deregistration/teardown, plugin visibility, dispatch routing
  • §12 conformance (renumbered from §11) — orchestrator MUST key manifest by quintuple; serve session-aware list queries

Companion

BRIDGE-1 §4.4 (PR #43) documents the satellite skill registration pattern this spec enables.

Every registration is automatically keyed by the session_id from the
registration message context — no shape change needed. The effective
intent pool for session X = default intents ∪ session-X intents −
blacklisted. "default" is the global/inherited scope; all sessions
inherit it. Session-scoped registrations extend, never narrow; the
blacklist is the sole narrowing mechanism.

Changes:
- §1 scope: add session-scoped registration to the defined list
- §8.1: replacement key is now quintuple (session_id, skill_id,
  intent_name, lang, method)
- §8.4: ovos.skill.deregister gains optional session_id field for
  satellite bulk-cleanup on disconnect
- §10.1: ovos.intent.list gains optional session_id filter; when
  provided returns effective pool (default ∪ session-specific);
  each response entry now includes session_id
- §11 (new): session-scoped registration — indexing model,
  inheritance rule, deregistration/teardown, plugin visibility,
  dispatch routing (transparent via existing MSG-1 destination)
- §12 conformance (renumbered from §11): orchestrator MUST now
  key manifest by quintuple and serve session-aware list queries

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented May 28, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 99476e55-c1c6-46d6-8a10-412961a61a17

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch spec/intent4-session-scoped

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

session_id must come from Message.context["session"]["session_id"],
not from Message.data. Reading from data would let a producer
register intents under an arbitrary session it does not own;
context is set by the session the producer is running under and
cannot be forged by payload content.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@JarbasAl

Copy link
Copy Markdown
Member Author

Merge-ready (MERGEABLE, dev merged in). Template conformance: header present, RFC-2119 boilerplate present, §11 session-scoped registration section well-formed with sub-sections 11.1–11.5. Added: CHANGELOG entry for the §11 addition (normative content was added without one). session_id sourced from context.session.session_id per §11.1 (correct per MSG-1/SESSION-1). Note: after #55 merges, GLOSSARY.md in this branch will need ovos-intent-*.md links updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant