Repository navigation
feat(us): match 6 more library functions - #28
Merged
Merged
Conversation
A Sonnet pass over the library functions left after OpenThievius#27 (the 23 with no attempt that compiled and the 31 more than 60 lines from retail) matched 6: func_00201A18, func_00209CB8, func_0020B2E8 (a jump table), func_0020C1A0, func_0020E120 and func_0020E8A0. func_00201A18 writes a hardware register through volatile, which AGENTS.md allows. Verified: every worker EXACT re-checked with python3 tools/check.py in us and eu; all 124 functions in the three library files touched print EXACT; python3 tools/build.py prints MATCH: build/us/SCUS_971.98 sha1 57dc305db57932ad3f1122966cdb695d2e62a47a with 3383 functions from C; the PAL build still matches; python3 tools/version_check.py wrote 64 absent, 3 differs, 3387 match; python3 -m unittest discover -s tests is OK; python3 tools/progress.py --check exits 0; python3 tests/check_repository.py prints ok: 0 problem(s). US is 4,265 of 4,770 functions (77.18% of code), PAL 4,261 of 4,795 (76.75%).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
6 library functions matched (US). A Sonnet pass covered the library functions left after #27: the 23 with no attempt that compiled and the 31 more than 60 lines from retail. It matched func_00201A18, func_00209CB8, func_0020B2E8 (jump table), func_0020C1A0, func_0020E120 and func_0020E8A0.
volatile, whichAGENTS.mdallows.tools/permute.py.What you verified
python3 tools/check.pyin US and PAL, and all 124 functions in the three library files touched print EXACT.python3 tools/build.pyprintsMATCH: build/us/SCUS_971.98 sha1 57dc305db57932ad3f1122966cdb695d2e62a47a with 3383 functions from C.python3 tools/build.py --version euprintsMATCH: build/eu/SCES_509.17 sha1 f23240fc4a3efd463a5b3617b9250da4d5fe842c.python3 tools/version_check.pywrote 64 absent, 3 differs, 3387 match.python3 -m unittest discover -s testsprintsOK.python3 tools/progress.py --checkexits 0.python3 tests/check_repository.pyprintsok: 0 problem(s).US is 4,265 of 4,770 functions (77.18% of code), PAL 4,261 of 4,795 (76.75%).