Skip to content

New macro: Jasmer Challenge filter - #20

Open
JGaardDK wants to merge 1 commit into
OpenSAK-Org:mainfrom
JGaardDK:ADD-Jasmer-Challenge
Open

JGaardDK wants to merge 1 commit into
OpenSAK-Org:mainfrom
JGaardDK:ADD-Jasmer-Challenge

Conversation

@JGaardDK

Copy link
Copy Markdown

Jasmer Challenge filter based on a found database and a databse of candidates

Macro

macros/

What changed

Checklist

  • [X ] Only one folder under macros/ is changed
  • [X ] The header has Name, Author, Version, Description, Requires-API and Permissions
  • [X ] Version is higher than the version already in the repository (if the .lua file changed)
  • [X ] Permissions and Network match what the code actually does
  • [X ] The README says what the macro does and how to use it
  • [X ] No personal data in example files or screenshots
  • [X ] I tested the macro in OpenSAK
  • [X ] I agree to publish this under the repository's MIT License

Jasmer Challenge filter based on a found database and a databse of candidates
@github-actions github-actions Bot added the needs review Waits for a maintainer label Nov 18, 2026
@AgreeDK

AgreeDK commented Nov 18, 2026

Copy link
Copy Markdown
Member

@JGaardDK
Thanks for the macro, and welcome! The checks pass and the logic is sound. A few things before we merge:

Step 1 counts every cache in database B as covered, including unfound ones. If someone picks the wrong database as B, months get marked as covered by mistake. Please add found = 1 to that query.
The placed date column is hidden_date. It’s part of the documented macro API (“Database tables for macros”), so you can use it directly instead of looking it up.
Please add -- Headless: no to the header. The macro needs its form and shows the result in the cache list, so it can’t run from the command line.
Optional but nice: a ## Changes section at the end of the README, e.g. - 1.4 — first version in OpenSAK-Macros.

Push the changes to the same branch and the PR updates itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs review Waits for a maintainer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants