fix(benchmarks): keep config imports safe for workflow sandboxes - #116
Merged
Merged
Conversation
devin-ai-integration Bot
added a commit
that referenced
this pull request
Sep 25, 2026
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Importing the benchmark config crashes Temporal workflow initialization because it also initializes the Effect model service, which writes
Error.stackTraceLimitafter Temporal freezes globals. Keep the config import free of that service initialization.What changed?
stripVariantSuffixhelper into the constants module and import it directly from the benchmark config.Error.How to test
Validated commit
e1d6728d9dc88f7da5405085b98fae481642c94cwith an isolated install from the committed lockfile:bun run format:check: passed.bun run check: passed, with existing warnings outside the changed files.bun run typecheck: passed.bun test: 1,562 passed, 0 failed.bun run build: passed.Attempted to assign to readonly property; restoring the fix makes it pass. The working tree is clean.CI validation passed. The original failure is captured by the downstream production Temporal bundle test. The full downstream integration test must be rerun after syncing the merged fix.
Reviewer focus
The helper behavior and existing model-module export are unchanged. This PR is the upstream prerequisite for the harness sync in openrouter-web #47047. The monorepo subtree accepts merged upstream
mainsnapshots only; no vendored source changes are included there.