Skip to content

fix(bench): record the effective search request body #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jamespsterling wants to merge 2 commits into
base: main
Choose a base branch
from
+9 −3
Open

fix(bench): record the effective search request body #114

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
20c9e81
fix(bench): keep effect/Context out of config schemas and record the …
jamespsterling Sep 24, 2026
72f82c9
merge origin/main; drop model-slug module superseded by #116
jamespsterling Sep 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/benchmarks/search/core/solver.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -318,9 +318,11 @@ describe("searchSolver", () => {
});
it("appends the switchyard-router plugin after the serialized web plugin", async () => {
let sentOptions: ResponsesSendOptions | undefined;
let sent: ResponsesRequest | undefined;
const solver = searchSolver(
{
send: (_body, options) => {
send: (body, options) => {
sent = body;
sentOptions = options;
return effectSucceed(fixtureResult({ text: "x" }));
},
Expand All @@ -332,7 +334,7 @@ describe("searchSolver", () => {
switchyardAlgorithm: "stage",
}
);
await runSolver(
const state = await runSolver(
solver(initialTaskState({ id: "s", input: "q", target: { text: "t" } }))
);
expect(sentOptions?.extraBody).toEqual({
Expand All @@ -341,6 +343,7 @@ describe("searchSolver", () => {
{ id: "switchyard-router", algorithm: "stage" },
],
});
expect(state.requestBody).toEqual({ ...sent, ...sentOptions?.extraBody });
});
it("sends only the switchyard-router plugin with server tools, ignoring the variant suffix", async () => {
let sentOptions: ResponsesSendOptions | undefined;
Expand Down
5 changes: 4 additions & 1 deletion src/benchmarks/search/core/solver.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,7 @@ export function searchSolver(
return completedState({
state,
request: body,
extraBody,
result,
attemptResults,
text: result.text.trim(),
Expand Down Expand Up @@ -262,12 +263,14 @@ function makeStreamEventReporter(
function completedState({
state,
request,
extraBody,
result,
attemptResults,
text,
}: {
readonly state: TaskState;
readonly request: ResponsesRequest;
readonly extraBody: Readonly<Record<string, unknown>> | undefined;
readonly result: ResponsesResult;
readonly attemptResults: readonly ResponsesResult[];
readonly text: string;
Expand Down Expand Up @@ -304,7 +307,7 @@ function completedState({
: []),
],
responseItems: responseItemsForCall(request, result),
requestBody: { ...request },
requestBody: { ...request, ...extraBody },
Comment thread
devin-ai-integration[bot] marked this conversation as resolved.
output: definedValues({
completion: text,
message: { role: MessageRole.Assistant, content: text },
Expand Down
Loading