Repository navigation
feat: mods give movies in WebM or Matroska - #1335
Merged
Merged
Conversation
… Vorbis sound Mod makers work in modern formats, and a sharper movie made with an upscaler is easiest to ship as WebM. For a movie name.bik, a mod's name.webm comes first, then name.mkv, then the Bink movie, as music takes the first of its formats. OpenReliant reads the Matroska container itself and decodes VP9 with FFmpeg's own decoder, so nothing new is linked. A modern movie is drawn at the size of the Bink movie it replaces, read from that movie's header, and keeps the rates the rooms and the transitions force, so it fits wherever the game's movie did. Its colours follow what the video says, BT.709 or full range, and BT.601 otherwise. The mods log names the movie it replaces. Closes #1179
The Matroska module joins the root's imports, so the suite always runs its tests. A movie's own timing moves into its source, so the player never reads an inactive union field. The mods log's lookups share one check of the game's files, the head readers mirror the stored readers and use the standard library's Dir.readFile, and the movie player's log messages share one format.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A mod can replace a Bink movie with a WebM or Matroska file of VP9 video, with Opus or Vorbis sound or none.
name.bik, a mod'sname.webmcomes first, thenname.mkv, then the Bink movie, as music takes the first of its formats.src/formats/matroska.zigreads the container: tracks, clusters of known or unknown size, simple blocks and block groups, all three lacings.--originaltoo. One with nothing to replace is drawn at its own size.replaces the movie warty_.bik.Left for later: AV1 (#1334).
Closes #1179