Repository navigation
feat: a HUD display can change its layout after it registers - #1331
Merged
Merged
Conversation
A display's layout and parts were fixed when it registered, so a display
whose layout depends on the window, as the Recommissioned HUD fits the
radio's window into its frame, had to register a new display each time
the window changed, and stopped following it past 24.
hud.set_display_layout(name, { layout = ..., parts = ... }) replaces a
display's layout and parts with the checks register_display makes: a
field left out stays as it was, and a mistake changes nothing. They go
back as they were as soon as the display is turned off, fails or its mod
stops, as before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A display's
layoutandpartswere fixed when it registered. A display whose layout depends on the window, such as the Recommissioned HUD fitting the radio's window into its own frame, had to register a new display each time the window changed, and stopped following it past 24 registrations.hud.set_display_layout(name, { layout = ..., parts = ... })replaces a display'slayoutandparts, with the checksregister_displaymakes. A field left out stays as it was, and a mistake changes nothing.set_display_enableddoes.Checked with a new test: a display moves the clock after it registers and keeps its parts, a bad layout changes nothing, and other names come back false.
Closes #1028