Repository navigation
feat: the log names a mod's sprite shape that is cut short - #1329
Merged
Merged
Conversation
A shape whose rows run past its block, as a broken set from a mod can hold, reads as a placeholder and draws nothing, and nothing said so, so a mod's author saw a piece of the display go missing with no hint why. The sprite reader now tells such a shape from the game's own placeholders by its sane bounds (spr.Sprite.cutShort), and wherever OpenReliant opens a set, the log names each one: the display's set, the front end's and the dialogs' sets, the ship schematics and the scripts' own sets. None of the 325 shipped sets has one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A shape whose rows run past its block, as a broken set from a mod can hold, reads as a placeholder and draws nothing. Nothing said so, so a mod's author saw a piece of the display go missing with no hint why.
spr.Sprite.cutShorttells such a shape from the game's own placeholders by its header's sane bounds.hud.warnCutShortlogs each one as a set is opened: the display's set, the front end's and the dialogs' sets, the ship schematics and the scripts' own sets.Checked: none of the 325 shipped sets has a cut-short shape (144 placeholders, all with nonsense bounds), so the game's own sets stay quiet. A mod with a
HUDHARD.SPRcut short by two bytes logsHUDHARD.SPR: shape 410 is cut short: its rows run past the end of its block, so it draws nothing.Closes #1079