Repository navigation
build: FFmpeg's source paths come out the same on every system - #1328
Merged
Merged
Conversation
FFmpeg's assertion messages hold their source files' paths (__FILE__). A build on Windows wrote the package's folders with backslashes and a cross-build with slashes, so the release's openreliant.exe differed from a cross-build of the same commit by those paths alone. Clang's -ffile-reproducible writes them with the target's separators, so both now hold the same paths: a cross-build for Windows writes zig-pkg\<package>\libavcodec\options.c, as Windows does.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FFmpeg's assertion messages hold their source files' paths (
__FILE__). A build on Windows wrote the package's folders with backslashes, and a cross-build with slashes. So the release'sopenreliant.exediffered from a cross-build of the same commit by those paths alone.deps/ffmpegcompiles with Clang's-ffile-reproducible, which writes__FILE__with the target's separators, whatever system builds it.Checked: a cross-build for
x86_64-windows-gnufrom macOS (--release=fast -Dstrip, as the release builds) now holds FFmpeg's paths aszig-pkg\N-V-…\libavcodec\options.c, with no slashes left. That's what a build on Windows writes with the flag. A byte-for-byte comparison needs a Windows build of the same commit: the next release, or a manual run of the release workflow.Closes #1162