Repository navigation
fix(levels): Yeedil passes the object to func_L03_00326458 - #444
Merged
Merged
Conversation
The call relied on the object still being in a0; the C now passes it, as Endako's calls do, and declares the argument. Same bytes (tools/check.py: 20_yeedil OK). Without it the PC port called the routine with a stray pointer and crashed on Yeedil.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Yeedil's func_L20_00310E38 called
func_L03_00326458()with no argument, relying on the object still being in a0. It now passes the object, the same way Endako's calls do, and declares the argument. The output is byte-identical: tools/check.py reports 20_yeedil OK, 1 of 1 places. Without this, the PC port called the routine with a stray pointer and crashed on Yeedil.