NMS-19927: Metadata-Driven Kafka Metric Topic Routing - #8823
NMS-19927: Metadata-Driven Kafka Metric Topic Routing#8823christianpape wants to merge 2 commits into
Conversation
christianpape
commented
Aug 27, 2026
christianpape
commented
- JIRA: https://opennms.atlassian.net/browse/NMS-19927
cgorantla
left a comment
cgorantla
left a comment
There was a problem hiding this comment.
This looks good. Some comments and also this needs to be re-targeted on foundation-2026
| description = "Show the Kafka topic that metrics for the given node, interface or service are routed to.") | ||
| @Service | ||
| @SuppressWarnings("java:S106") | ||
| public class MetricRoutingTest implements Action { |
There was a problem hiding this comment.
Check if this still works if metric routing is disabled. Users might want to run this command without enabling routing.
There was a problem hiding this comment.
This works when metric routing is disabled. In this case, a message appears stating that it is disabled and that the default theme is being used.
| String metricTopic = null; | ||
| boolean disableMetricsSplitting = false; | ||
| String metricFilter = null; | ||
| boolean metricRoutingEnabled = false; |
There was a problem hiding this comment.
One thing to note with activator, this might not reload bundle when config gets updated. So if config gets updated after feature resolution, bundle/feature might need to be restarted
There was a problem hiding this comment.
Added a note to the docs.
2a85cd4 to
869f2da
Compare
2 participants
