Repository navigation
feat: Attack Shark R5 Ultra support - #91
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds Attack Shark R5 Ultra (VID 0x373e, PIDs 0x0046 wired / 0x0047 wireless) support to the app.
Changes:
src/device/traits.ts:attack-sharkfamily maps to DIRECT_MODE;Attack Sharkbrand maps to the family.src/check-scan.ts: 0x373E label nowLamzu / CRDRAKO / Attack Shark.src/preview-fixtures.ts+src/preview-modes.ts: R5 Ultra preview fixture/mode.src/ui/device-images.ts+public/devices/attackshark-r5-ultra.png: product artwork for both PIDs.src/ui/device-images.test.ts: artwork resolution coverage.Verification:
npm run checkpasses, 59/59 tests.Note:
@openmouse/protocoltemporarily points at the fork (jazzstack/mouse-protocol#main) until the matching protocol PR (OpenMouse-Project/mouse-protocol#15) lands; revert to the upstream URL after it merges.