Repository navigation
Fix the tab nav dropping below the MX Master cards on Advanced - #84
Merged
snekxs merged 1 commit intoAug 14, 2026
Merged
Conversation
Every workspace panel is placed by a per-id flex `order` rule, with the sticky tab nav at order 1. The MX Master settings section was the only panel without an id, so it fell to the default order 0 and rendered above the nav — pushing the tab bar into the middle of the Advanced tab, below the four cards, where a tall tab scrolls it out of reach. Give the section an id and an order (5, just before Device details), matching how every sibling panel is already positioned. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012pZcQpyw9YNZE1yy5LcXxX
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On a Logitech MX Master, the Advanced tab renders its tab-bar nav in the
middle of the page, below the Haptics / MagSpeed / Friendly name / Easy-Switch
cards instead of above them. On a tab tall enough to scroll, that parks the nav
off the top of the viewport, so it looks like the navigation has disappeared and
there is no way back to the other tabs.
Cause
The panel layout places every workspace section with a per-id flex
order(
#performance-settingsorder 3,#lighting-settings4,#logitech-onboard5,#logitech-device-details6, … the sticky tab nav is order 1). The MX Mastersettings section is the one panel with no id, so it fell to the default
order: 0and rendered ahead of the nav.Fix
Give that section an id (
logitech-mx-master-settings) and anorder(5, justbefore Device details), matching how every sibling panel is already positioned.
Two lines; no behaviour change beyond the nav returning to the top.
Scope
Independent of any device protocol — pure layout. Pre-existing on
dev: the MXMaster card group is a
<section>from #82, and the id-based ordering that therest of the panels use was never applied to it.
Testing
npm run checkgreen.top, above Haptics, with the four cards below it, then Device details and
Diagnostics in their existing order.