Skip to content

Fix the tab nav dropping below the MX Master cards on Advanced - #84

Merged
snekxs merged 1 commit into
OpenMouse-Project:devfrom
weltern:fix/mx-master-advanced-tab-order
Aug 14, 2026
Merged

snekxs merged 1 commit into
OpenMouse-Project:devfrom
weltern:fix/mx-master-advanced-tab-order

Conversation

@weltern

@weltern weltern commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

On a Logitech MX Master, the Advanced tab renders its tab-bar nav in the
middle of the page
, below the Haptics / MagSpeed / Friendly name / Easy-Switch
cards instead of above them. On a tab tall enough to scroll, that parks the nav
off the top of the viewport, so it looks like the navigation has disappeared and
there is no way back to the other tabs.

Cause

The panel layout places every workspace section with a per-id flex order
(#performance-settings order 3, #lighting-settings 4, #logitech-onboard 5,
#logitech-device-details 6, … the sticky tab nav is order 1). The MX Master
settings section is the one panel with no id, so it fell to the default
order: 0 and rendered ahead of the nav.

Fix

Give that section an id (logitech-mx-master-settings) and an order (5, just
before Device details), matching how every sibling panel is already positioned.
Two lines; no behaviour change beyond the nav returning to the top.

Scope

Independent of any device protocol — pure layout. Pre-existing on dev: the MX
Master card group is a <section> from #82, and the id-based ordering that the
rest of the panels use was never applied to it.

Testing

  • npm run check green.
  • Confirmed on hardware (MX Master 4): the Advanced tab's nav renders at the
    top, above Haptics, with the four cards below it, then Device details and
    Diagnostics in their existing order.

Every workspace panel is placed by a per-id flex `order` rule, with the sticky
tab nav at order 1. The MX Master settings section was the only panel without
an id, so it fell to the default order 0 and rendered above the nav — pushing
the tab bar into the middle of the Advanced tab, below the four cards, where a
tall tab scrolls it out of reach.

Give the section an id and an order (5, just before Device details), matching
how every sibling panel is already positioned.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012pZcQpyw9YNZE1yy5LcXxX
@snekxs
snekxs merged commit a8d0281 into OpenMouse-Project:dev Aug 14, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants