Repository navigation
fix(polling): show unknown rates without selecting a fallback - #693
Merged
snekxs merged 3 commits intoOct 8, 2026
Merged
Conversation
snekxs
marked this pull request as ready for review
October 8, 2026 21:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a driver reports an unavailable polling rate (
0or a non-finite value), OpenMouse currently prints0 Hzand selects the nearest button, usually 125 Hz. Display a dash and leave all buttons unselected instead. Known positive rates retain the previous nearest-step behavior.Update the performance readout and controller status line, and add two dev previews:
?preview=pulsar-xs1-8kand?preview=pulsar-xs1-unknown. These cover the shared Pulsar 8K receiver's recognized and unknown-read states. Polling remains read-only for this XS-1 driver; DPI and other controls stay available.Companion protocol change: OpenMouse-Project/mouse-protocol#185. It fixes the
3710:5403capability list and stops fabricating 1000 Hz on a failed query. The UI change also handles the existing unavailable-rate sentinel used by other drivers, so it can merge independently. The released npm dependency remains unchanged; the protocol-update workflow can adopt the new release.Validation: build and all 294 tests passed both with the current stable dependency and the locally packed protocol change. Bundle-size check passed. Browser DOM checks confirmed the unknown-rate dash with no selected rate button, and the recognized 8K state with its disabled 8K button selected. This was checked in the Codex browser, not presented as a physical mouse or Chrome hardware test.