Repository navigation
build: raise the bundle budgets after the protocol 0.26.0 batch - #620
Merged
Merged
Conversation
Both budgets were effectively exhausted, so the next card, theme or driver change would have tripped npm run size for no reviewable reason: CSS 194157 / 195000 bytes (100%) -> 210000 (92%) JS 2084199 / 2085000 bytes (100%) -> 2150000 (97%) The JS growth is the protocol 0.26.0 device batch: AJAZZ AJ179 PRO (#169), Redragon M690 PRO (#163, wired into the panel by #617), Lamzu Paro Aurora (#172), plus the X11-on-Bridge (#174), PRO X Wireless format 4 (#175) and Logitech onboard-profile (#166/#589) work. Their protocol codecs arrive through bridge-hid's SUPPORTED_HID_FILTERS as well as the controllers. Measured with a clean npm ci against the committed lockfile, after npm run build: CSS 194.2 kB, JS 2,084.2 kB.
Deploying openmouse with
|
| Latest commit: |
ae94d3d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://8e06ef76.openmouse.pages.dev |
| Branch Preview URL: | https://chore-raise-bundle-budgets.openmouse.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both budgets were down to under 1 kB of headroom, so the next card, theme or driver change would fail
npm run sizeon an unrelated PR:The JS growth is this week's protocol 0.26.0 device batch — AJAZZ AJ179 PRO (#169), Redragon M690 PRO (#163, wired into the panel by #617), Lamzu Paro Aurora (#172), plus the X11-on-Bridge (#174), PRO X Wireless format 4 (#175) and Logitech onboard-profile (#166/#589) work. Their codecs reach the bundle through bridge-hid's
SUPPORTED_HID_FILTERSas well as the controllers.Measured with a clean
npm ciagainst the committed lockfile, afternpm run build:Follows the file's existing convention: each raise records the measured aggregate and what drove it, so the next person can tell a justified growth from an accidental one.
npm run checkpasses 290/290.