Repository navigation
Revert "feat: add AJAZZ AJ179 PRO artwork mapping (#599)" - #613
Merged
Merged
Conversation
The mapping resolved AJAZZ AJ179 PRO to https://img.openmouse.app/ajazz-aj179-pro.png, which returns 404. Device images are not stored in this repository: they are uploaded by the maintainer to Cloudflare R2 and served from img.openmouse.app, so this PR shipped a mapping to an asset that does not exist yet. Reverting keeps main from pointing at a missing render. The mapping logic itself is sound and can be re-landed once the artwork is in R2, alongside mouse-protocol#169.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #599.
src/ui/device-images.tsresolved AJAZZ AJ179 PRO tohttps://img.openmouse.app/ajazz-aj179-pro.png, which returns 404. Device artwork is not stored in this repository — the images are uploaded by the maintainer to Cloudflare R2 and served fromimg.openmouse.app— so the PR shipped a mapping to an asset that does not exist.The mapping logic is fine (model-name resolution, PRO MAX exclusion, sibling-PID guard all verified) and can be re-landed once the render is in R2.