Repository navigation
Conversation
Adds FaterHidClient to NEEDS_OPEN so the read-only Holtek driver from mouse-protocol opens its vendor collection on connect. No traits entry: the driver exposes no sleep or debounce card. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Member
|
Status check: correctly staying draft — Leave this until the companion mouse-protocol PR merges + publishes and the protocol bump workflow picks it up. The one-line NEEDS_OPEN hunk itself looks right. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #394 once the driver ships.
Adds
FaterHidClient(Holtek 04d9:a09f, "E-Signal" firmware) toNEEDS_OPEN. The driver lives in the companion mouse-protocol PR; this stays a draft until that is released and@openmouse/protocolis bumped here.The driver is read-only (polling rate and active profile) because no capture of this mouse exists. Its frame is borrowed from two decodes of the same Holtek OEM firmware family (hv-ms735-config for the HAVIT MS735, and the HP G360 tool). DPI lives in a 128-byte config page that WebHID on Windows cannot read, so it waits for a USBPcap capture of the vendor app.
Verified locally against the mouse-protocol branch:
tsc --noEmitandvite buildpass. Not tested on hardware; the issue reporter offered to test.