Skip to content

Add Noir Gear NOIR E1 support - #476

Merged
snekxs merged 1 commit into
OpenMouse-Project:mainfrom
williamsnoirgear:feat/noir-e1-pr
Oct 3, 2026
Merged

snekxs merged 1 commit into
OpenMouse-Project:mainfrom
williamsnoirgear:feat/noir-e1-pr

Conversation

@williamsnoirgear

Copy link
Copy Markdown
Contributor

Summary

  • Add NOIR E1 as a distinct K-snake/Noir Gear model, including exact-name resolution for its shared PID with M2-NEX.
  • Enable E1's supported DPI stages, button remapping, scroll direction, macros, and six local profiles stored separately from M2-NEX.
  • Add E1 artwork mapping and the underside DPI-button marker.

The artwork image is not included in this PR, following the repository artwork workflow. I will submit it separately through the device-artwork issue form for maintainer upload.

Verification

  • npm run check (build + 259 tests)

@snekxs

snekxs commented Oct 3, 2026

Copy link
Copy Markdown
Member

Rebased this onto main with S1 (#452) merged — the two PRs touched the same Noir/K-snake surface (noir.ts, m2nex-profiles, controller, OverviewPage, Dpi/Advanced/Performance cards) and conflicted across 9 files.

Pushed a conflict-resolved branch to resolve/noir-e1-rebase on origin (commit 737be49): unions S1+E1 identity helpers, profile-store options, marker tables, DPI single-view gating for both models. tsc clean, 265/265 tests pass.

Maintainer can't push to the fork branch, so either:

  1. git fetch origin resolve/noir-e1-rebase && git checkout -B feat/noir-e1-pr FETCH_HEAD && git push from your fork, or
  2. say the word and I'll open a fresh PR from resolve/noir-e1-rebase and close this one.

Also noting: main now has keychron-8k/keychron-1k traits (#514), no interaction with this PR.

@snekxs
snekxs merged commit c816aa6 into OpenMouse-Project:main Oct 3, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants