fix(logitech): treat the PRO X Wireless (0xc094) as format 4 - #175
Merged
Merged
Conversation
A sector-1 dump from a real 0xc094 (main app MPM25.01_B0018) reports profile format 4 - the base v1 scalar table - not the format 7 the per-stage lift-off guard assumed. V1 has no per-stage lift-off byte, so the product guard has nothing to refuse there; it now only applies to v6 layouts, which keeps the protection for a unit that does report a v6 format. Correct the comment and docs, and pin the captured geometry (format-4 info reply, CRC-valid sector 1, 800 DPI first stage at 1000 Hz) in a regression test. Closes #159
|
🎉 This PR is included in version 0.26.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A sector-1 dump from a real
0xc094(main appMPM25.01_B0018) reports profile format 4 - the base v1 scalar table - not the format 7 the per-stage lift-off guard was written for. Base v1 has no per-stage lift-off byte at all, so the product guard has nothing to refuse on this device;isLodWritableForProductnow applies the guard only to v6 layouts, which keeps the protection if a unit ever does report a v6 format.The dump is pinned in
onboard-profiles.test.ts: the framed info reply01 0d 00 01 04 01 05 01 05 10 00 ff 0a 04 00 00, a CRC-valid sector 1, and the first stage20 03= 800 DPI at 1000 Hz. The comment anddocs/logitech-onboard-profiles.mdare corrected to match.Verification:
onboard-profiles.test.ts66/66; decode also checked against the builtdist.Closes #159