fix(attackshark): enable the X11 on the rebuilt Bridge config path - #174
Merged
Merged
Conversation
A genuine X11 (0xfa60, receiver model id 0x55) over OpenMouse Bridge was refused by X11_REBUILT_CONFIG_MODELS, which only listed the Delux M600 Pro, so x11ConfigReachable stayed false and the mouse was status-only even though Bridge can reach the vendor feature reports. This is the failure reported in issue #161. Add 0x55: same receiver, protocol and rebuilt transport as the verified M600 Pro, with the receiver's documented 56-byte DPI frame. Models whose frame shape is not established (R1, X3, X6) stay read-only. The Bridge diagnostic is recorded under captures/attackshark-x11/. The write still wants confirmation on X11 hardware before release. Refs #161
5 tasks
|
🎉 This PR is included in version 0.26.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Genuine X11 units (
0x1d57:0xfa60, receiver model id0x55) were refused byX11_REBUILT_CONFIG_MODELS, which only listed the Delux M600 Pro (0x20). Over OpenMouse Bridge the rebuilt config collection carries no report sizes, sox11ConfigReachablestayed false and the mouse was status-only even though Bridge can reach the vendor feature reports - the failure in #161.Add
0x55: it rides the same receiver, protocol and rebuilt transport as the verified M600 Pro and resolves to the receiver's documented 56-byte DPI frame (x11UsesShortDpiReportreturns the long form for0xfa60). Models whose frame shape is not established (R10x10, X30x4d/0x4e, X60x85) stay read-only.Evidence: the reporter's Bridge diagnostic is recorded under
captures/attackshark-x11/; the packet shapes are the ones already verified through Bridge for the M600 Pro (captures/delux-m600-pro/windows-bridge.txt).The write has not yet been observed on X11 hardware. @sLimbutin - could you confirm DPI, polling and battery on a build of this branch before we call it done?
Refs #161