Repository navigation
Fix several gameplay and server bugs - #373
Merged
Merged
Conversation
- Plant soil: only a grown plant can be harvested - Guild devices: fuel below the price of one charge is refused, charges are added correctly, accepted fuel is used up - Vertigo: restore might and aim of monsters correctly - Sweep: respect the same item restrictions as picking up - Distill, create scroll: pay the rest of the reagents from further stacks - Trance: take back exactly the speed change it applied - Shadow step: limit the range to 3 squares for ranged weapons - Brittle: fix sign of the damage bonus (since bb34f10) - Arena watcher: restore mana and vigor on leaving, restore stats when the fight is cleared - Illusions no longer count for quests and events - Phase: only clear the attack timer where phase can be cast - Admin: show a post body as text, not as a format string
Targeted spells (e.g. detect invisible) cast with nothing selected are applied to the caster, but SpellMurmurMessage still built the targeted message and sent GetIndef/GetName to a nil target, flooding the log. Fall back to the untargeted gesture message in that case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes for bugs found during a review:
Notes:
that ReqNewOwnerAttributes should be called from ReqNewOwner.
step.
Tested on a local server, except illusions and phase, which were not tested in game.