Skip to content

Fix several gameplay and server bugs - #373

Merged
skittles1 merged 2 commits into
OpenMeridian105:developfrom
Arantis:security-fixes
Nov 10, 2026
Merged

skittles1 merged 2 commits into
OpenMeridian105:developfrom
Arantis:security-fixes

Conversation

@Arantis

@Arantis Arantis commented Nov 9, 2026 •

Copy link
Copy Markdown

Fixes for bugs found during a review:

  • Plant soil: only a grown plant can be harvested
  • Guild devices: fuel below the price of one charge is refused, accepted fuel is used up
  • Vertigo: restores might and aim of monsters correctly
  • Sweep: respects the same item restrictions as picking up
  • Distill, create scroll: pay remaining reagents from further stacks
  • Trance: takes back exactly the speed change it applied
  • Shadow step: range limited to 3 squares for ranged weapons
  • Brittle: fixes the sign of the damage bonus (since bb34f10)
  • Arena watcher: restores mana and vigor on leaving, and stats when the fight is cleared
  • Illusions no longer count for quests and events
  • Phase: only clears the attack timer where phase can be cast
  • Admin: shows a post body as text, not as a format string

Notes:

  • Sweep: this is the small fix. The underlying issue is
    that ReqNewOwnerAttributes should be called from ReqNewOwner.
  • Shadow step: if it becomes too strong, a cooldown or vigor cost would be the next
    step.
  • New string GuildDevice_too_little_fuel, so clients need the new rsc0000.rsb.

Tested on a local server, except illusions and phase, which were not tested in game.

- Plant soil: only a grown plant can be harvested
- Guild devices: fuel below the price of one charge is refused, charges are
  added correctly, accepted fuel is used up
- Vertigo: restore might and aim of monsters correctly
- Sweep: respect the same item restrictions as picking up
- Distill, create scroll: pay the rest of the reagents from further stacks
- Trance: take back exactly the speed change it applied
- Shadow step: limit the range to 3 squares for ranged weapons
- Brittle: fix sign of the damage bonus (since bb34f10)
- Arena watcher: restore mana and vigor on leaving, restore stats when the
  fight is cleared
- Illusions no longer count for quests and events
- Phase: only clear the attack timer where phase can be cast
- Admin: show a post body as text, not as a format string
@skittles1 skittles1 added this to the 3.0.8 milestone Nov 9, 2026
Targeted spells (e.g. detect invisible) cast with nothing selected are
applied to the caster, but SpellMurmurMessage still built the targeted
message and sent GetIndef/GetName to a nil target, flooding the log.
Fall back to the untargeted gesture message in that case.
@skittles1
skittles1 merged commit 211862e into OpenMeridian105:develop Nov 10, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants