Repository navigation
Rework loot chests: key opens for 15 minutes, nothing stays inside - #371
Merged
Merged
Conversation
A key now fills the chest and opens it for 15 minutes. When the time runs out the chest closes and deletes everything inside, so a locked chest is empty and replaces the limit on entries. Players can't put items in, nothing can be taken while it is locked, and an open chest doesn't use up another key. The description shows the time left. Existing chests still hold their old items, so run this once after the update: send class LootChest DeleteHolding
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rework loot chests
Replaces the entry limit from the previous fix.
New behaviour
Security
Items could be taken from a locked chest without a key, because only the object flag blocked it. With a description window left open, the classic client could still reach the items. Locked loot chests are now empty, and taking from them is refused on the server.
Other chests using
pbLocked(bandit cave, golem dungeon, marcry3a, ratcave2, necromancer chest) are not changed.Run once after the update
Existing chests still hold their old items, so empty them once: